Add gallery example "Scale bar" #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvonnefroehlich
added
the
documentation
|
/format |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
seisman
reviewed
Dec 19, 2023
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
| # ----------------------------------------------------------------------------- | ||
| # Add a thick scale bar | ||
| # Adjust the GMT default parameter MAP_SCALE_HEIGHT locally (the change applies | ||
| # only to the code within the "with" block) |
There was a problem hiding this comment.
Suggested change
| # only to the code within the "with" block) | |
| # only to the code within the "with" statement) |
There was a problem hiding this comment.
Hm. I am still not 100 % sure whether within the "with" statement sounds better than within the "with" block and makes sense. Maybe we can write under the "with" statement if we want to use statement instead of block?
There was a problem hiding this comment.
I feel 'within the "with" statement' is better.
There was a problem hiding this comment.
OK. Should I also update the formulations in the Figure.inset line example:
Lines 119 to 131 in 06ae818
yvonnefroehlich
added
the
needs review
seisman
reviewed
Dec 20, 2023
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
seisman
approved these changes
Dec 23, 2023
seisman
approved these changes
Dec 24, 2023
seisman
added
final review call
seisman
removed
the
final review call
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR aims to add a gallery example showing how to configurate a scale bar:
pygmt.Figure.basemap)Upstream GMT documentation:
Preview: https://pygmt-dev--2822.org.readthedocs.build/en/2822/gallery/embellishments/scalebar.html
Fixes #2627
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version